-
Notifications
You must be signed in to change notification settings - Fork 219
Prepare release 0.9.1 #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
840c7a7
to
1cbdb50
Compare
1cbdb50
to
0ea6c9f
Compare
0ea6c9f
to
2071536
Compare
2071536
to
9317ef9
Compare
@sosthene-nitrokey I don't think we should block this on #571 and just get it merged. |
#571 is not a "blocker" but I'd rather do the breaking change before releasing (especially given that the PR has been reviewed and is only one nitpick being resolved away from being merged) rather than #571 ending up being blocked forever on a new breaking release to be merged. I reworded the pr description to remove the "blocked on", if you judge #571 should be ignored. |
That makes sense to me. On the other hand I personally find it a bit frustrating that I initially made the I don't say that to justify that my PR should be merged, but to explain why I wanted those breaking changes included before the next release. I understand that maintainer bandwidth can be scarce so it makes sense to not prioritize small ergonomic improvements over releasing what's already there, so if you want to release 0.9.0 as-is it's fine by me. |
@sgued I think we're ready to release? I hope we have the rights to push releases. :) Could you rebase so the we merge it and push to crates.io and push the tag here? |
9317ef9
to
c0184b5
Compare
Yup, I planned to bring it up in the meeting this evening. |
@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. | |||
The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
## [Unreleased] | |||
## [v0.9.1] - 2025-08-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say the same to you here, what I was told for 0.9.0. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
This is a breaking change, 0.9.0 should be yanked. See rust-embedded#568
c0184b5
to
0a764cd
Compare
I think these should be merged first