Draft: Support thumb-mode Armv7-R, Armv7-A and Armv8-R #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumps the arm-targets MSRV to 1.83 to make the CI pipeline simpler
We missed this because we weren't testing examples
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
24e6f70 to
96f06f3
Compare
Contributor
Author
|
In order to be able to test thumb-mode Armv7-R and Armv7-A, we need to be able to mark some functions as being compiled in Thumb mode. However, the armv7a, armv7r and armv8r targets didn't have the thumb-interworking option set. They now do, but only in the latest nightly, not the last stable. I'm wondering in the QEMU tests should always just use nightly and not bother with stable? |
Contributor
Author
|
Or I guess I could write the function in assembly code... |
Now has thumb interworking on all {arm,thumb}*-none-eabi* targets.
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
96f06f3 to
7ef1f3a
Compare
Contributor
Author
|
Rebased so it uses #100, and modified to run QEMU tests on nightly (although the libraries themselves are still build on stable and our MSRV). |
Contributor
Author
|
My justfile changes aren't right - this should fail the build due to missing targets upstream and it does not. |
Also relies on all the targets having thumb-interworking enabled.
Thanks, macOS :/
You can't depend on the flags because they vary depending on what the machine code does.
thejpster
force-pushed
the
support-thumb-mode-v7-v8
branch
from
f02a244 to
7f0a85b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also relies on all the targets having thumb-interworking enabled.