feat(env_filter): implement Clone for Filter #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of possible use-cases for Filter would be using it as a CLI argument, so the user can configure the logger without setting any environment variables. Right now it isn't possible to use Filter as a CLI argument in clap, because clap requires all CLI arguments to implement Clone.
Pull Request Test Coverage Report for Build 18447261517Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of possible use-cases for Filter would be using it as as CLI argument, so the user can configure the logger without setting any environment variables. Right now it is not possible to use Filter as a CLI argument in the clap crate, because clap requires all CLI arguments to implement Clone.
Passing Filter through CLI can be especially useful on Windows, because there is no way (in either
cmdorPowershell) to set an environment variable just for a command invocation like in bash. E.g.