chore(deps): Switch humantime to jiff #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
oherrala
force-pushed
the
jiff
branch
2 times, most recently
from
1b3d072 to
0cab95a
Compare
Pull Request Test Coverage Report for Build 13769764634Details
💛 - Coveralls |
BurntSushi
reviewed
Mar 8, 2025
oherrala
force-pushed
the
jiff
branch
3 times, most recently
from
0b268ef to
8ec73fa
Compare
epage
reviewed
Mar 10, 2025
Humantime seems to be unmaintained and jiff provides same functionality.
|
Thanks! |
This was referenced Mar 10, 2025
github-merge-queue bot
pushed a commit
to rust-lang/cargo
that referenced
this pull request
Mar 10, 2025
<!-- Thanks for submitting a pull request 🎉! Here are some tips for you: * If this is your first contribution, read "Cargo Contribution Guide" first: https://doc.crates.io/contrib/ * Run `cargo fmt --all` to format your code changes. * Small commits and pull requests are always preferable and easy to review. * If your idea is large and needs feedback from the community, read how: https://doc.crates.io/contrib/process/#working-on-large-features * Cargo takes care of compatibility. Read our design principles: https://doc.crates.io/contrib/design.html * When changing help text of cargo commands, follow the steps to generate docs: https://github.com/rust-lang/cargo/tree/master/src/doc#building-the-man-pages * If your PR is not finished, set it as "draft" PR or add "WIP" in its title. * It's ok to use the CI resources to test your PR, but please don't abuse them. ### What does this PR try to resolve? Explain the motivation behind this change. A clear overview along with an in-depth explanation are helpful. You can use `Fixes #<issue number>` to associate this PR to an existing issue. ### How should we test and review this PR? Demonstrate how you test this change and guide reviewers through your PR. With a smooth review process, a pull request usually gets reviewed quicker. If you don't know how to write and run your tests, please read the guide: https://doc.crates.io/contrib/tests ### Additional information Other information you want to mention in this PR, such as prior arts, future extensions, an unresolved problem, or a TODO list. --> The crate [`humantime`](https://crates.io/crates/humantime) appears to be unmaintained. There's open PR in RustSec's advisory-db about this: rustsec/advisory-db#2249 The crates [`clap`](https://crates.io/crates/clap) and [`env_logger`](https://crates.io/crates/env_logger) have already made the switch from `humantime` to [`jiff`](https://crates.io/crates/jiff): * clap-rs/clap#5944 * rust-cli/env_logger#352 The `jiff` crate is already dependency on `cargo` via `gix` (albeit old 0.1 version, but that's probably fixed in [next gix release](GitoxideLabs/gitoxide@3ae99a4)): ``` jiff v0.1.29 └── gix-date v0.9.3 ├── gix v0.70.0 │ └── cargo v0.88.0 (/Users/oherrala/rust/cargo) ``` This PR shouldn't have any functional change to cargo itself.
|
|
|
Note that the addition of jiff means env_logger is pulling a number of extra dependencies: portable-atomic, portable-atomic-util, serde (including serde_derive and all the proc-macro stuff). Not sure this is a good deal from that perspective. (Independent from my having taken over maintenance of humantime.) |
|
Yes I agree, I have a little intention to propose a revert to this PR. |
They might show up in your lock file because of rust-lang/cargo#10801, but serde, proc macros are all opt-in features that |
|
@BurntSushi good to know! We should really get that Cargo bug fixed sometime... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
humantimeseems to be unmaintained andjiffprovides the same functionality. This change shouldn't affect end users.Ref. rustsec/advisory-db#2249