Fix typos in the external-symbols feature(bug)#199
Fix typos in the external-symbols feature(bug)#199apoelstra merged 2 commits intorust-bitcoin:masterfrom
Conversation
apoelstra
left a comment
There was a problem hiding this comment.
ACK. Surprised the compiler didn't complain about our check on the feature dont_replace_c_symbols when no such feature is defined in our Cargo.tomls.
Sadly I think the current way cargo+rustc implements features this isn't possible, so rustc will accept whatever I will open a cargo issue about it but I'm not sure this is even technically possible to implement with the current architecture. |
Hi,
This was introduced in #169
There was a typo in some of the feature gates from
external-symbolstoexternal_symbols.it wasn't caught because it was either not
pub extern "C"(likesecp256k1_context_create) or prefixed with therustsecp256k1_v0_1_1_*which made it not collide with other symbols.Second thing is we still have some leftovers from the
dont_replace_c_symbolsfeature (#177) which we no longer support since #169 was merged and prefixed all the symbols so they're not really easily usable in C/C++ code anyway.this feature isn't in our Cargo.toml anyway so these are no-ops anyway now.