Skip to content

use hex-conservative 1.0 rc1 everywhere for decoding #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apoelstra
Copy link
Member

It turns out we only ever use do decoding of fixed test vectors. It would be nice to have a hex! macro for this. Eventually.

In some cases we were able to use inherent methods on bitcoin types -- for example ScriptBuf::from_hex or deserialize_hex.

@apoelstra apoelstra marked this pull request as draft May 22, 2025 20:53
@apoelstra
Copy link
Member Author

Drafting. Might as well just wait for the real 1.0.

@apoelstra apoelstra force-pushed the push-ppmrkrkvqkzo branch 2 times, most recently from 9b75aec to fb0adc3 Compare May 22, 2025 20:57
It turns out we only ever use do decoding of fixed test vectors. It
would be nice to have a hex! macro for this. Eventually.

In some cases we were able to use inherent methods on bitcoin types --
for example ScriptBuf::from_hex or deserialize_hex.
@apoelstra apoelstra force-pushed the push-ppmrkrkvqkzo branch from fb0adc3 to bea8cde Compare May 23, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant