Add verifymessage feature #343
Conversation
tcharding
force-pushed
the
05-01-verifymessage-feature
branch
from
806b654 to
af014db
Compare
tcharding
force-pushed
the
05-01-verifymessage-feature
branch
from
af014db to
40d91e1
Compare
|
Can you switch the commits? Currently the first one doesn't compile. |
In rust-bitcoin#326 we changed a function to use `bitcoin::sign_message::MessageSignature` but doing so requires the "base64" feature to be on for `bitcoin`. This did not get caught by CI but improvements to CI in rust-bitcoin#338 will now catch this. Add a feature to `json` and `client` that allows enabling "base64" if the `verifymessage` RPC call is required.
MSRV build just broke because of a bunch of dependencies. I did not investigate why I just found a set of versions that builds.
tcharding
force-pushed
the
05-01-verifymessage-feature
branch
from
40d91e1 to
56d62dc
Compare
Oh you build each commit before merging, nice. I have not been doing that when merging things. Lesson learned. I added feature gating to the import as well which got lost somehow. I thought about it this morning, glad I got to add it. |
|
So, I'm unsure about this PSBTs are also base64-encoded and this is handled in the PSBT API by just taking PSBTs as |
I'll do that, thanks. |
|
Done as a separate PR because it is totally different to this so using this PR would make the discussion confusing. That is a new process idea I just had, please comment if its worse. Thanks for the review too @apoelstra, I know you are travelling and this is not the most exciting thing to be fixing while doing so. Appreciate the input. |
|
Close this if/when #349 goes in. |
In #326 we changed a function to use
bitcoin::sign_message::MessageSignaturebut doing so requires the "base64" feature to be on forbitcoin. This did not get caught by CI but improvements to CI in #338 will now catch this.Add a feature to
jsonandclientthat allows enabling "base64" if theverifymessageRPC call is required.