Add '()' annotation and error handling to submit_header #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I got that... Thank you. |
GideonBature
force-pushed
the
submitheader
branch
from
1012724 to
d3a047e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch for PR #259 that adds a
let _: () = ...annotation and an.expect("submitheader")call to the integration test forsubmit_header.The
.expect()call is necessary to extract the()value from the result returned bysubmit_header, making the test both explicit and consistent with the other null-returning client function tests.Also, Introduced a for loop to increment the header’s nonce until the PoW is valid. This ensures the header meets Bitcoin’s difficulty target before calling
submit_header.