Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process.warmupの記述を追加 #2890

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Conversation

bmf-san
Copy link
Contributor

@bmf-san bmf-san commented Jun 6, 2024

Ruby3.3より追加されたProcess.warmupについての記述を追加しました。
cf. https://docs.ruby-lang.org/en/3.3/Process.html#method-c-warmup

Issue: #2873

@ohai
Copy link
Member

ohai commented Jun 8, 2024

PRありがとうございます。3.3以降,ということで

#@since 3.3
   : 
#@end

で囲んでください。

@bmf-san
Copy link
Contributor Author

bmf-san commented Jun 8, 2024

@ohai
ご確認ありがとうございます :D

対応しました!
7d3ea76

@ohai
Copy link
Member

ohai commented Jun 8, 2024

--- warmup -> true の手前にsicneを入れてください。

@bmf-san bmf-san force-pushed the add-process-warmup branch from a031a8f to f6c138d Compare June 8, 2024 10:30
@bmf-san
Copy link
Contributor Author

bmf-san commented Jun 8, 2024

@ohai
修正しました🙏

@ohai ohai merged commit d5298d4 into rurema:master Jun 8, 2024
8 checks passed
@ohai
Copy link
Member

ohai commented Jun 8, 2024

マージしました。ありがとうございます。

On CRuby, Process.warmup: ... の部分もあるとより良いですがまあそれはそれで。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants