Add Array#intersection since Ruby 2.7 #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
commented
May 21, 2020
refm/api/src/_builtin/Array
Outdated
| @@ -1138,6 +1138,34 @@ self 以下のネストしたオブジェクトを dig メソッドで再帰的 | |||
| ary.insert(-2, "X") | |||
| p ary # => [1, 2, "a", "b", "X", 3] | |||
|
|
|||
| #@since 2.7.0 | |||
| --- intersection(*other_arrays) -> Array | |||
| --- &(other_array) -> Array | |||
There was a problem hiding this comment.
intersection と & は厳密には違うメソッドなのですが、違うメソッドでもひとまとまりになっていることは多いし、ひとまとまりに書いてみました。
ただ、intersectionと&で引数名が違う(&は引数を1つしか取らないので)のはちょっと微妙かなあという気もしています。どうでしょうか？
There was a problem hiding this comment.
よくみたらArray#&はRuby 2.7以前でも存在していてドキュメントもすでにあるので、 8b20336 でintersectionと&を足していたのは & の定義が2重になってしまっていました。
そのため、 intersection と & を別のメソッドとして書いて、それぞれsee alsoのリンクをはるようにしました。
pocke
commented
May 21, 2020
| s1 = Set[10, 20, 30] | ||
| s2 = Set[10, 30, 50] | ||
| p s1 & s2 #=> #<Set: {10, 30}> | ||
| #@end |
znz
reviewed
May 26, 2020
refm/api/src/set.rd
Outdated
| #@end | ||
|
|
||
| #@since 2.7.0 | ||
| @see [[m:Array#intersection]] |
There was a problem hiding this comment.
Array#&へのリンクを追加しました 👌 d8afdc0
znz
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2071
Ruby 2.7 から追加された Array#intersection 及び Arrary#& のドキュメントを追加します。
また、Set#intersectionから see also のリンクを貼っています。
サンプルコードはRDocのものを使っています。スタイルだけ少し手直ししました。
RDoc: