Repository navigation
test: serve the HTTP integration tests from a loopback server - #516
Merged
Merged
Conversation
Run-Id: w:20261023T023341Z-45fb4d
Run-Id: w:20261023T025350Z-9d4fcc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP integration tests called an external host, which now returns 503 and fails the integration job on main. CI should reach only package registries and GitHub.
test/integration/loopback_http.dartstarts an HTTP server on127.0.0.1with an ephemeral port. It answers any GET with a small JSON body,/largewith a body over 64 KiB, and paths under/slow/after 150 ms.setUpAlland register its close at once, separately from the pool's. EveryHttpClientconnects directly, so a proxy in the environment cannot route loopback traffic./slow/paths, because the crash they guard needs I/O that takes over 100 ms.Local checks:
dart analyze --fatal-infos test/integrationclean,tool/dcm_host_gate.shgreen,tool/test_cell.sh vmwith the worker hook: integration 709 passed (floor 657), acceptance 12, portable 69.Pre-PR review
Two review passes. The first asked for delayed responses in the #271 tests, cleanup that survives a failed pool start or close, and direct connections. All three are in the second commit. Reviewed at f0ec163.