Skip to content

test: serve the HTTP integration tests from a loopback server - #516

Merged
runyaga merged 2 commits into
mainfrom
test/loopback-http
Oct 23, 2026
Merged

runyaga merged 2 commits into
mainfrom
test/loopback-http

Conversation

@runyaga

@runyaga runyaga commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

The HTTP integration tests called an external host, which now returns 503 and fails the integration job on main. CI should reach only package registries and GitHub.

  • test/integration/loopback_http.dart starts an HTTP server on 127.0.0.1 with an ephemeral port. It answers any GET with a small JSON body, /large with a body over 64 KiB, and paths under /slow/ after 150 ms.
  • The five test files that used the external host start the server in setUpAll and register its close at once, separately from the pool's. Every HttpClient connects directly, so a proxy in the environment cannot route loopback traffic.
  • The four FFI SEGFAULT: use-after-free on sequential async host function calls in single session #271 tests use the /slow/ paths, because the crash they guard needs I/O that takes over 100 ms.
  • Test counts are unchanged.

Local checks: dart analyze --fatal-infos test/integration clean, tool/dcm_host_gate.sh green, tool/test_cell.sh vm with the worker hook: integration 709 passed (floor 657), acceptance 12, portable 69.

Pre-PR review

Two review passes. The first asked for delayed responses in the #271 tests, cleanup that survives a failed pool start or close, and direct connections. All three are in the second commit. Reviewed at f0ec163.

@github-actions github-actions Bot added the test label Oct 23, 2026
@runyaga
runyaga marked this pull request as ready for review October 23, 2026 03:16
@runyaga
runyaga merged commit 197ea05 into main Oct 23, 2026
16 checks passed
@runyaga
runyaga deleted the test/loopback-http branch October 23, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant