Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse bytes #516

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Sparse bytes #516

merged 7 commits into from
Nov 10, 2023

Conversation

bbyalcinkaya
Copy link
Member

No description provided.

@bbyalcinkaya bbyalcinkaya marked this pull request as ready for review November 3, 2023 12:33
Copy link
Contributor

@virgil-serbanuta virgil-serbanuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC you measured a performance change for this PR, could you add it to the PR description?

@@ -50,4 +50,83 @@ module FUNCTIONS-SPEC
</instrs>
requires 0 <=Int ADDR

claim <instrs> run ( substrSparseBytes(_SB, S, _E) ) => done ( .SparseBytes ) ... </instrs> requires S <Int 0
claim <instrs> run ( substrSparseBytes(_SB, _S, E) ) => done ( .SparseBytes ) ... </instrs> requires E <Int 0
claim <instrs> run ( substrSparseBytes(_SB, S, E) ) => done ( .SparseBytes ) ... </instrs> requires E <Int S
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding tests for the other cases?

@bbyalcinkaya bbyalcinkaya merged commit 822d849 into master Nov 10, 2023
6 checks passed
@bbyalcinkaya bbyalcinkaya deleted the sparse-bytes branch November 10, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants