Skip to content

Conversation

@dkcumming
Copy link
Collaborator

Previously in the happy case result was returned, but that may be a different error unrelated to signers which will then get propagated by inner_test_validate_owner.

@dkcumming dkcumming marked this pull request as ready for review November 29, 2025 15:12
dkcumming and others added 2 commits November 30, 2025 11:29
Previously in the happy case `result` was returned, but that may be a
different error unrelated to signers which will then get propagated by
`inner_test_validate_owner`.
* Fixes to SPL cheat code helper functions
* SPL Rent cheat code support
* support transmute to/from `MaybeUninit` (for `iter()`)
* data-length support for SPL cheat code structures
@dkcumming dkcumming force-pushed the dc/progagation-error branch from cc72796 to 477f9e2 Compare November 30, 2025 01:29
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

return result;
}

return Ok(());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most important change, avoids erroring out at the call site.

if mint_authority_new.is_some() {
// Validate Owner
inner_test_validate_owner(
mint_authority_new.unwrap(), // expected_owner
&accounts[2], // owner_account_info
&accounts[3..], // tx_signers
maybe_multisig_is_initialised,
result.clone(),
)?;

@dkcumming dkcumming merged commit 379a954 into proofs Dec 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants