Skip to content

Conversation

@Stevengre
Copy link

@Stevengre Stevengre commented Nov 25, 2025

@Stevengre Stevengre self-assigned this Nov 25, 2025
@Stevengre
Copy link
Author

Stevengre commented Nov 25, 2025

I found a compiling error with ./setup.sh on my macbook, but it doesn't occur on the linux server.

ValueError: Cannot parse as UnionT: {'UnionType': {'name': 'std::mem::MaybeUninit<std::arch::aarch64::uint8x8_t>', 'adt_def': 204, 'layout': {'fields': {'Union': 2}, 'variants': {'Single': {'index': 0}}, 'abi': {'Vector': {'element': {'Union': {'value': {'Int': {'length': 'I8', 'signed': False}}}}, 'count': 8}}, 'abi_align': 8, 'size': {'num_bits': 64}}}}

Solved by updating stable-mir-json suggested by @dkcumming

@Stevengre Stevengre marked this pull request as ready for review November 25, 2025 14:16
Copy link
Collaborator

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, it didn't dive through it in explicit detail but it looks like the same approach as p-token. A note, it might be worth adding the cheatcode_is_spl_account for the authority for every non-multisig case or you are going to have the branches that go into the Multisig case in the implementation like what is happening with P-Token

@Stevengre
Copy link
Author

A note, it might be worth adding the cheatcode_is_spl_account for the authority for every non-multisig case or you are going to have the branches that go into the Multisig case in the implementation like what is happening with P-Token

will change this for the next pr.

@Stevengre Stevengre merged commit 002e50b into proofs Nov 26, 2025
1 check passed
@Stevengre Stevengre deleted the jh/spl/separate-multisig branch November 26, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants