Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter and normalise json output for golden test runs #24

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

dkcumming
Copy link
Collaborator

@dkcumming dkcumming commented Jan 15, 2025

This PR adds functionality to filter and normalise the json output when comparing output to the golden tests. Some cases when we want to normalise output:

  1. "NormalSym" mangled function names will have a hash following 17h that will change when the compiler version changes.
<         "NormalSym": "_ZN3std2rt19lang_start_internal17h3166ab4c34d1da61E"
---
>         "NormalSym": "_ZN3std2rt19lang_start_internal17h51b943990c0e2c96E"
                                                        ^----can ignore---^
  1. "symbol_name" mangled function names will have a hash following 17h that will change when the compiler version changes.
<       "symbol_name": "_ZN4core3ops8function6FnOnce9call_once17h40ba616aaa505a69E"
---
>       "symbol_name": "_ZN4core3ops8function6FnOnce9call_once17hd98db8d17b807164E"

@dkcumming dkcumming self-assigned this Jan 15, 2025
@dkcumming dkcumming requested a review from jberthold January 15, 2025 03:47
@dkcumming dkcumming changed the base branch from internalize_rust_fork_code to master January 15, 2025 04:33
@dkcumming dkcumming changed the base branch from master to internalize_rust_fork_code January 15, 2025 04:35
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Have to check what happened to the test workflow...

@dkcumming dkcumming merged commit 1478638 into internalize_rust_fork_code Jan 15, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants