Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial CI setup and a few tests #21

Merged
merged 12 commits into from
Nov 18, 2024
Merged

Initial CI setup and a few tests #21

merged 12 commits into from
Nov 18, 2024

Conversation

jberthold
Copy link
Member

@jberthold jberthold commented Nov 12, 2024 •
edited
Loading

  • Simple CI setup to build and test smir_pretty
  • a directory of small test programs and golden files to compare to (json to be formatted and normalised using jq)
  • resolve issues with toolchain setup (from prior runs?) on runners
  • analyse and fix Rust build artefact caching

Related: #20

@jberthold jberthold marked this pull request as ready for review November 12, 2024 06:42
@jberthold jberthold marked this pull request as draft November 12, 2024 06:42
@jberthold jberthold force-pushed the initial-golden-tests branch from 62fc5ff to ed8a273 Compare November 12, 2024 22:39
@jberthold jberthold marked this pull request as ready for review November 12, 2024 22:40
@jberthold jberthold marked this pull request as draft November 13, 2024 09:41
@jberthold jberthold force-pushed the initial-golden-tests branch from b3504f4 to 1487672 Compare November 17, 2024 23:59
jberthold
jberthold commented Nov 18, 2024
View reviewed changes
tests/integration/failing/array.rs Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most files in this directory fail the test because their functions array content is not deterministic, the integers paired with the function names are different in different runs.

jberthold
jberthold commented Nov 18, 2024
View reviewed changes
tests/integration/failing/panic_example.rs Outdated
Copy link
Member Author

@jberthold jberthold Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails because of a Static element in the allocs. None of the other tests EDIT: A few of the other tests also have such a Static element.

jberthold
jberthold commented Nov 18, 2024
View reviewed changes
.github/workflows/test.yml
Comment on lines +57 to +60
- name: 'Clean up toolchain'
if: always()
run: |
make rustup-clear-toolchain
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important, otherwise the build will leave a dangling toolchain behind that rustup stumbles upon during setup. I opened a ticket for this against dtolnay/rust-toolchain@.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solution is already merged @jberthold

@jberthold jberthold requested a review from dkcumming November 18, 2024 03:27
@jberthold jberthold marked this pull request as ready for review November 18, 2024 03:27
dkcumming
dkcumming approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay it all looks sensible to me. I think this is great for merge

@dkcumming dkcumming merged commit a823e31 into master Nov 18, 2024
1 check passed
@jberthold jberthold deleted the initial-golden-tests branch January 13, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkcumming dkcumming dkcumming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jberthold @dkcumming