This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Hotfix for the handling of bottom and top for the CTerm class
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwatson22
suggested changes
Aug 31, 2023
There was a problem hiding this comment.
I looked at this and it sounds like you were correct about what the problem is. We just need to make sure we aren't calling CTerm.from_kast on a term that could still possibly be a disjunction of terms, so run the flatten_label('#Or'... before it's converted to a CTerm.
nwatson22
approved these changes
Sep 25, 2023
tothtamas28
approved these changes
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#621 introduced a bug, it was falsely simplifying to
Bottombecause it was returning the disjunct of all states when using theprove_ctermendpoint. This got uncovered as part of runtimeverification/evm-semantics#2041