This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Exporting get_requires utils function
#1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rv-jenkins
pushed a commit
to runtimeverification/llvm-backend
that referenced
this pull request
Apr 2, 2024
This is a requirement from the Math Proof Generation Team of $Piˆ2$ to get easy access to the Pattern of a requires clause. This PR must be merged before this [PyK PR](runtimeverification/pyk#1056) that will properly expose this binding to the Pi2 project.
tothtamas28
reviewed
Apr 3, 2024
Hasn't there been a plan to eventually implement it in |
That was revisited, and we decided to move in another direction to avoid having the exact implementation in two different places when we could just export them. |
I've just added a unit test, and I'm waiting for this PR to be approved |
tothtamas28
reviewed
Apr 3, 2024
Robertorosmaninho
force-pushed
the
get-requires-utils
branch
from
e9cbe24 to
ca02a8b
Compare
tothtamas28
approved these changes
Apr 3, 2024
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <[email protected]>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
This PR introduces a new file, `utils.py`, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object. In this context we're using a function from llvm backend's [pattern_matching.cpp](https://github.com/runtimeverification/llvm-backend/blob/e2f583a05b9bf362deabd58f8acc1ce534aaf4c4/lib/ast/pattern_matching.cpp#L174) to avoid reimplement it in Python. This function is exported as Pyhton binding in this [PR](runtimeverification/llvm-backend#1019), and therefore, the current PR can only be merged after we merge the LLVM Backend one. --------- Co-authored-by: devops <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new file,
utils.py, which should contain auxiliary functions that need to be converted from and to llvm but don't set any field on an object.In this context we're using a function from llvm backend's pattern_matching.cpp to avoid reimplement it in Python. This function is exported as Pyhton binding in this PR, and therefore, the current PR can only be merged after we merge the LLVM Backend one.