-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure configuration to support referencing multiple contracts #318
Open
sskeirik
wants to merge
27
commits into
master
Choose a base branch
from
contracts_map
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good. I found a few rules that needed to specify |
sskeirik
force-pushed
the
contracts_map
branch
5 times, most recently
from
August 4, 2021 22:23
7ae7f28
to
5194d31
Compare
…plify reasoning needed for DEXTER-ADDLIQUIDITY-POSITIVE-SPEC
sskeirik
force-pushed
the
contracts_map
branch
from
August 14, 2021 02:00
4eff752
to
411379e
Compare
$ sed -i 's/contracts>/accounts>/g' $(git grep -l '<contracts>') $ sed -i 's/currentContract>/currentAccount>/g' $(git grep -l '<currentContract>')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: I forgot to update the
<knownaddrs>
cell to use the new mechanism, so I will defer this update.