Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure configuration to support referencing multiple contracts #318

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

sskeirik
Copy link
Collaborator

@sskeirik sskeirik commented Jul 8, 2021

EDIT: I forgot to update the <knownaddrs> cell to use the new mechanism, so I will defer this update.

@sskeirik sskeirik requested a review from nishantjr July 8, 2021 00:13
@sskeirik sskeirik marked this pull request as draft July 8, 2021 00:17
@nishantjr
Copy link
Contributor

nishantjr commented Jul 8, 2021

Looks good. I found a few rules that needed to specify <currentAccount> and fixed them. Once you've reviewed that lets merge.

@sskeirik sskeirik force-pushed the contracts_map branch 5 times, most recently from 7ae7f28 to 5194d31 Compare August 4, 2021 22:23
@sskeirik sskeirik marked this pull request as ready for review August 14, 2021 02:01
$ sed -i 's/contracts>/accounts>/g' $(git grep -l '<contracts>')
$ sed -i 's/currentContract>/currentAccount>/g' $(git grep -l '<currentContract>')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants