Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Custom Kontrol Versions using a workflow #941

Merged

Conversation

F-WRunTime
Copy link
Member

  • Adding a new feature to build kontrol images using kup and --overrides

Supports using custom test builds in kaas and local

- Adding a new feature to build kontrol images using kup and --overrides
F-WRunTime and others added 5 commits January 23, 2025 10:54
modified:   .github/workflows/kup-build-kontrol.yml
- Standardizing the naming between these two workflows to know which is
  for which
- Docker-push builds a custom version of kontrol with fixed dependencies
  already published and built with kontrol
- kup-build-kontrol.yml will build the existing kontrol code with a
  single new
  dependency
modified:   README.md
- Adding some readme instructions.
…ol-push-fixed-deps.yml

renamed:    .github/workflows/kup-build-kontrol.yml -> .github/workflows/kontrol-push-unfixed-deps.yml
modified:   README.md
- Add some background between the two kontrol build workflows
-- Adding content to explain the two custom kontrol build workflows
@F-WRunTime F-WRunTime self-assigned this Jan 23, 2025
asavienko

This comment was marked as resolved.

Co-authored-by: Anton Savienko <[email protected]>
@F-WRunTime

This comment was marked as resolved.

- Adding instructions to fetch hash and use the wrofklow with multiple
  dep options now available
- Fixing reporting of final versions used to build kontrol.
- Removing dfining override for undefined inputs to the workflow
@F-WRunTime F-WRunTime requested a review from jberthold January 23, 2025 23:24
@F-WRunTime
Copy link
Member Author

F-WRunTime commented Jan 23, 2025

Final example of latest test run through in devops-actions

https://github.com/runtimeverification/devops-actions/actions/runs/12939752629

@ehildenb ehildenb dismissed asavienko’s stale review January 23, 2025 23:45

Comments addressed.

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 8d7b584 into master Jan 24, 2025
12 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the feature/kontrol-kup-built-images branch January 24, 2025 00:33
ACassimiro added a commit that referenced this pull request Jan 24, 2025
* Implement kevm.forgetBranch cheatcode (#899)

* draft FOUNDRYSemantics

* forgetBranch

* add mlEqualsTrue

* minor corrections

* add simplification step

* formatting

* add back not equal

* rename FOUNDRYSemantics to KontrolSemantics

* checking for negation as well

* correcting indentation

* expanding functionality

* heuristic simplifications

* further refinement

* refactoring _exec_forget_custom_step

* add show test

* fix test

* update expected output

---------

Co-authored-by: Petar Maksimovic <[email protected]>
Co-authored-by: Palina <[email protected]>
Co-authored-by: Petar Maksimović <[email protected]>

* Update dependency: deps/kevm_release (#940)

* deps/kevm_release: Set Version 1.0.780

* Sync Poetry files: kevm-pyk version 1.0.780

* flake.{nix,lock}: update Nix derivations

---------

Co-authored-by: devops <[email protected]>

* Build Custom Kontrol Versions using a workflow (#941)

* new file:   .github/workflows/kup-build-kontrol.yml
- Adding a new feature to build kontrol images using kup and --overrides

* Update .github/workflows/kup-build-kontrol.yml

Co-authored-by: Everett Hildenbrandt <[email protected]>

* modified:   .github/workflows/docker-push.yml
modified:   .github/workflows/kup-build-kontrol.yml
- Standardizing the naming between these two workflows to know which is
  for which
- Docker-push builds a custom version of kontrol with fixed dependencies
  already published and built with kontrol
- kup-build-kontrol.yml will build the existing kontrol code with a
  single new
  dependency
modified:   README.md
- Adding some readme instructions.

* renamed:    .github/workflows/docker-push.yml -> .github/workflows/kontrol-push-fixed-deps.yml
renamed:    .github/workflows/kup-build-kontrol.yml -> .github/workflows/kontrol-push-unfixed-deps.yml
modified:   README.md
- Add some background between the two kontrol build workflows

* modified:   README.md
-- Adding content to explain the two custom kontrol build workflows

* Update README.md

Co-authored-by: Anton Savienko <[email protected]>

* Filling in the 'get' placeholder with functionality to fetch appropriate
defaults when nothing is provided

* modified:   README.md
- Adding instructions to fetch hash and use the wrofklow with multiple
  dep options now available

* Update spelling and gramar

* modified:   .github/workflows/kontrol-push-unfixed-deps.yml
- Fixing reporting of final versions used to build kontrol.
- Removing dfining override for undefined inputs to the workflow

---------

Co-authored-by: Everett Hildenbrandt <[email protected]>
Co-authored-by: Anton Savienko <[email protected]>

---------

Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Petar Maksimovic <[email protected]>
Co-authored-by: Palina <[email protected]>
Co-authored-by: Petar Maksimović <[email protected]>
Co-authored-by: rv-jenkins <[email protected]>
Co-authored-by: devops <[email protected]>
Co-authored-by: Freeman <[email protected]>
Co-authored-by: Everett Hildenbrandt <[email protected]>
Co-authored-by: Anton Savienko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants