Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning on non-test analysis w/o foundry_success checking #432

Merged
merged 18 commits into from
Mar 16, 2024
Merged

Add a warning on non-test analysis w/o foundry_success checking #432

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e14dcb0
Added warning non a non-test analysis
lisandrasilva Mar 11, 2024
019b70c
Merge branch 'master' into lis/warn-no-test
lisandrasilva Mar 11, 2024
31ea195
Set Version: 0.1.195
Mar 11, 2024
05e5ba6
Addressed PR comments
lisandrasilva Mar 12, 2024
b4a7d6a
Merge branch 'master' into lis/warn-no-test
lisandrasilva Mar 13, 2024
efd7e23
changed from info to warning
lisandrasilva Mar 13, 2024
8bffdd7
Set Version: 0.1.200
Mar 13, 2024
5f7ccbc
Moved warning closer to the end of execution
lisandrasilva Mar 13, 2024
81d86c0
Print info after proof.status
lisandrasilva Mar 13, 2024
3b4cbab
Merge branch 'master' into lis/warn-no-test
lisandrasilva Mar 13, 2024
6fd4baf
Set Version: 0.1.201
Mar 13, 2024
84bbf86
Moved warning before proof status
lisandrasilva Mar 14, 2024
7e103af
Merge branch 'master' into lis/warn-no-test
lisandrasilva Mar 14, 2024
e2a18c7
Set Version: 0.1.204
Mar 14, 2024
4d022da
Merge branch 'master' into lis/warn-no-test
rv-jenkins Mar 14, 2024
554cedd
Set Version: 0.1.205
Mar 14, 2024
8ef8654
Merge branch 'master' into lis/warn-no-test
PetarMax Mar 16, 2024
3b01e82
Set Version: 0.1.208
Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package/version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.1.194
0.1.195
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "kontrol"
version = "0.1.194"
version = "0.1.195"
description = "Foundry integration for KEVM"
authors = [
"Runtime Verification, Inc. <[email protected]>",
Expand Down
2 changes: 1 addition & 1 deletion src/kontrol/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
if TYPE_CHECKING:
from typing import Final

VERSION: Final = '0.1.194'
VERSION: Final = '0.1.195'
4 changes: 4 additions & 0 deletions src/kontrol/prove.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,10 @@ def _method_to_cfg(
init_node = cfg.create_node(init_cterm)
new_node_ids = [init_node.id]
init_node_id = init_node.id
if not method.is_testfail and not method.is_test:
lisandrasilva marked this conversation as resolved.
Show resolved Hide resolved
_LOGGER.warning(
lisandrasilva marked this conversation as resolved.
Show resolved Hide resolved
f'{contract.name_with_path}.{method.signature} is not prefixed with test or testFail, therefore it is not being checked for failures.'
lisandrasilva marked this conversation as resolved.
Show resolved Hide resolved
)

final_cterm = _final_cterm(
empty_config, program, failing=method.is_testfail, is_test=method.is_test, is_setup=method.is_setup
Expand Down
Loading