Deprecate klabel attribute
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
requested review from
virgil-serbanuta,
tothtamas28,
bbyalcinkaya and
gtrepta
8 tasks
gtrepta
approved these changes
Jul 3, 2024
rv-jenkins
pushed a commit
to runtimeverification/k
that referenced
this pull request
Jul 4, 2024
This PR implements @tothtamas28's warning messages for usages of the deprecated `klabel(_)` and `symbol` attributes (which can now be unambiguously replaced by `symbol(_)` and `overload(_)`). The actual code changes are pretty minimal, but we need to do a bunch of updates on test cases and related output to keep tests passing. Additionally, we have pre-merged downstream PRs to make sure other projects are not subjected to noisy compiler output as a result of making this change: Downstream updates: - [x] C https://github.com/runtimeverification/c-semantics/pull/1125 - [x] EVM runtimeverification/evm-semantics#2378 - [x] WASM runtimeverification/wasm-semantics#666 - [x] MX Backend runtimeverification/mx-semantics#298 - [x] Kasmer runtimeverification/kasmer-multiversx#168 - [x] MIR (new semantics doesn't use `klabel`) - [x] Pyk (this PR, now that K and Pyk are merged) - [x] Blockchain Plugin runtimeverification/blockchain-k-plugin#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple mechanical change to remove the
klabel, symbolattribute pair in anticipation ofklabelfinally being deprecated; usages are replaced with 1-argumentsymbol(_).