Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional simplifications to avoid spurious branching on select result #158

Closed
wants to merge 6 commits into from

Conversation

jberthold
Copy link
Member

Companion PR to runtimeverification/wasm-semantics#655 .
A simplification is required to avoid a spurious branch in the call_add* proofs

@jberthold jberthold marked this pull request as ready for review June 22, 2024 11:47
@jberthold jberthold requested a review from bbyalcinkaya June 22, 2024 11:47
@ehildenb
Copy link
Member

@jberthold typically we would add claim ... which exercise the simplifactions, in order to test that the actual simplification we need is correctly being applied. This claim can be produced by extracitng out the original condition/term you wanted simplified as the LHS, and the RHS is what you wanted it simplified to. Taht way, we continue to test that we don't accidentally undo simplifications we care about into the future.

@virgil-serbanuta can let you know where to put such claims in this repo.

@jberthold
Copy link
Member Author

In order to get an example term that we want simplified, I tested the change to wasm-semantics with mx-backend's current master. It turned out that some other changes merged in the meanwhile seem to have removed the need for these simplifications. Closing for now

@jberthold jberthold closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants