Avoid clashes of generated declarations and Lean 4 #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
reviewed
Jan 21, 2025
There was a problem hiding this comment.
This should be handled in the generator, and maybe checked in the model.
There was a problem hiding this comment.
I'll leave this as a future item if/when work on this PR resumes.
pyk/src/pyk/k2lean4/model.py
Outdated
| @@ -7,6 +7,9 @@ | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from collections.abc import Iterable | |||
| from typing import Final | |||
|
|
|||
| _LEAN_KEYWORDS: Final = {'ite', 'end', 'where'} # Words that cannot be a the name of a declaration | |||
There was a problem hiding this comment.
end and where are keywords, ite is probably just a predefined function.
There was a problem hiding this comment.
I changed it to _LEAN_WORDS. Let me know if this notation is not desired, or if we should separate into two sets depending on keyword or definition.
|
I'll open an issue then, and leave finishing the rest of the work here for when we decide to tackle it 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some generated names might clash with Lean's built in declarations. For instance, generating the function symbols for
evm-semanticsproducesaxiom ite, which clashes with Lean:To avoid the clash error, it is now generated as:
Safeguards are put in place for other types of declarations, such as
inductive,structure,abbrevandinstance.