-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MergedEdge class for merging node functionality #4603
Conversation
Compared to #4600, the impact of this implementation is smaller, but it still has some effects. Specifically, for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some unit tests for a KCFG
containing MergedEdge
instances.
This commit adds these unit tests, but leaves the unit test for minimization for another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please test on evm-semantics
before merging.
|
cc1e353
to
c39310e
Compare
Please also run integration tests for |
c39310e
to
1ce88d7
Compare
After spending a long time configuring, I still couldn’t get the evm-semantics integration tests to run. So I decided to submit it as a PR and use the existing CI for testing. |
Here is the alternative implementation for this PR.
MergedEdge
to_rule
function toMergedEdge
for CSEEdge
forMergedEdge
Edge.to_rule
related functions for CSE