Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status bar improvements #4575

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Status bar improvements #4575

merged 4 commits into from
Aug 7, 2024

Conversation

nwatson22
Copy link
Member

@nwatson22 nwatson22 commented Aug 6, 2024

  • Adds the number of refuted nodes to the proof status bar.
  • Adds a separator which separates the one line summary into 3 parts, one which is the proof status, one to do with structure, and one to do with status of the leaves.
  • Changes the definition of branches to mean "how many Split and NDBranch targets are there?" instead of "how many Splits and NDBranches are there?" to more accurately reflect the degree of branching in a proof.

@nwatson22 nwatson22 self-assigned this Aug 6, 2024
@rv-jenkins rv-jenkins changed the base branch from master to develop August 6, 2024 16:16
@nwatson22 nwatson22 requested a review from PetarMax August 6, 2024 21:16
@nwatson22 nwatson22 marked this pull request as ready for review August 6, 2024 21:16
@PetarMax
Copy link
Contributor

PetarMax commented Aug 6, 2024

Great - could we please have a slightly different order, say:

pending-passed-failing-vacuous-refuted-stuck-terminal || (or some other separator) nodes-branches

Also, note that branches might not carry all of the information, since, for example, in minimised proofs I will likely have just one branching that goes many ways.

@nwatson22 nwatson22 changed the title Add number of refuted nodes to status bar display. Status bar improvements Aug 6, 2024
@PetarMax PetarMax merged commit a2b5a76 into develop Aug 7, 2024
22 of 47 checks passed
@PetarMax PetarMax deleted the noah/show-node-refutations branch August 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants