Make request IDs unique across clients #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
reviewed
Jul 16, 2024
|
@nwatson22, can you post the logs for an example multi-threaded run of |
Co-authored-by: Tamás Tóth <[email protected]>
tothtamas28
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
LGTM.
@geo2a, please check if this change is breaking for the Haskell backend testing automation.
|
@tothtamas28 @geo2a Here is a snippet of a run of a kontrol proof. Could you check that this will not break the bug report automation and @PetarMax that the requests are differentiated enough for debugging? |
|
Thanks @nwatson22 and @tothtamas28! Look good to me. @jberthold could you also have a look at the output above to make sure it's compatible? |
|
Yes, this will disambiguate sufficiently in debugging, I think. |
jberthold
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Thanks @nwatson22 and @tothtamas28! Look good to me. @jberthold could you also have a look at the output above to make sure it's compatible?
LGTM, too, I checked that we only use fromId and not assume the request ID is an Int in our code.
rv-jenkins
pushed a commit
that referenced
this pull request
Aug 29, 2024
Blocked on: * ~#4524~ Since transport-specific files are no longer added to the bug report (e.g. commands for sending a request), bug report handling can be performed in the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the ID fields of the requests being sent to the kore RPC server. Before they were just integers counting up the requests of each client, but it is useful to be able to see in the logs which requests are coming from which client, so this changes the IDs to be this same counter, but prepended with
id()of the client that is making the request.