Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old workaround #4485

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Remove old workaround #4485

merged 8 commits into from
Jun 27, 2024

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Jun 26, 2024

In 7ba37fb (8 years ago), we disabled cell collection syntax productions when parsing rules because of OOMs in the compiler. We haven't needed to use this syntax since then, but @PetarMax recently identified a lemma that required being able to do so.

@Baltoli Baltoli marked this pull request as ready for review June 27, 2024 10:24
@Baltoli
Copy link
Contributor Author

Baltoli commented Jun 27, 2024

I verified that KEVM builds successfully with this version of K, and @PetarMax confirmed that it fixes his issue.

Copy link
Contributor

@tothtamas28 tothtamas28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding!

@rv-jenkins rv-jenkins merged commit bf1e5e7 into develop Jun 27, 2024
18 checks passed
@rv-jenkins rv-jenkins deleted the permit-cell-collection branch June 27, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants