Expose -Wno via ignore-warnings kompile option
#4471
Conversation
|
@JuanCoRo you'll need to rebase out these version noise commits; PRs to K should be based on the |
|
Thanks @Baltoli! Let me know if this looks good. Forgot to start off |
pyk/src/pyk/cli/args.py
Outdated
| @@ -206,6 +206,7 @@ class KompileOptions(Options): | |||
| bison_lists: bool | |||
| no_exc_wrap: bool | |||
| outer_parsed_json: bool | |||
| ignore_warnings: list[str] | None | |||
There was a problem hiding this comment.
I'm not a 100% sure in this, but consider
| ignore_warnings: list[str] | None | |
| ignore_warnings: list[str] |
This makes it consitent with ccopts.
@nwatson22, is this the right convention to follow?
There was a problem hiding this comment.
Yes, I'd go without the None type option unless there is a situation where it could actually be set to None, which there shouldn't be as far as I know since you have [] as the default.
|
@tothtamas28 just addressed all comments above (hopefully). Let me know if there's anything I missed while we wait on @nwatson22's input on removing the |
This reverts commit 47594df.
|
@nwatson22 @tothtamas28 @Baltoli do you see anything missing in this PR? Need this one merged to start merging the upstream ones. Let me know if there's anything else from my side that needs to be done! |
Address #4470