Fix docs build release job #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
approved these changes
Jun 21, 2024
Comment on lines
+21
to
+23
| RUN if [ "${INSTALL_BACKEND_DEBS}" = "true" ]; then \ | ||
| apt-get -y install /llvm-backend.deb; \ | ||
| fi |
There was a problem hiding this comment.
We should clean this up a bit (in a different PR): the LLVM_BACKEND_DEB_PATH is required, even if INSTALL_BACKEND_DEBS is not true.
There was a problem hiding this comment.
yep, it's a slightly awkward design as it stands - will aim to clean up in a following PR per your comment below
| /llvm-backend.deb \ | ||
| /kframework.deb \ | ||
| && apt-get -y clean | ||
| /kframework.deb |
There was a problem hiding this comment.
So IIUC this Docker file is used with two kinds of kframework.deb: one that contains the LLVM backend and one that doesn't.
There was a problem hiding this comment.
Yep! We should clean that up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that's been breaking the Pyk documentation release jobs; the issue was that we were trying to install the standalone LLVM backend
.debpackage on top of an existing K installation that already contains the LLVM backend.The fix is to add a flag to the K Docker reusable action that allows the backend installation step to be skipped. You can see a successful run of the fixed workflow here: https://github.com/runtimeverification/k/actions/runs/9604052282/job/26489371015?pr=4464