Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor from_spec_modules in APRProof #4447

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Conversation

tothtamas28
Copy link
Contributor

@tothtamas28 tothtamas28 commented Jun 17, 2024

  • Move ProveRpc, ClaimIndex into separate modules
  • Add parameter ordered to ClaimIndex.labels to enable topological sorting of the result
  • Implement APRProof.from_spec_modules using ClaimIndex

@tothtamas28 tothtamas28 self-assigned this Jun 17, 2024
@rv-jenkins rv-jenkins changed the base branch from master to develop June 17, 2024 16:38
@tothtamas28 tothtamas28 marked this pull request as ready for review June 17, 2024 20:01
Copy link
Contributor

@gtrepta gtrepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tothtamas28 tothtamas28 force-pushed the refactor-proof-from-modules branch from 3abe98a to a568a71 Compare June 22, 2024 11:19
@tothtamas28 tothtamas28 force-pushed the refactor-proof-from-modules branch from a568a71 to 64a365d Compare June 22, 2024 11:30
@rv-jenkins rv-jenkins merged commit 67eff5d into develop Jun 24, 2024
18 checks passed
@rv-jenkins rv-jenkins deleted the refactor-proof-from-modules branch June 24, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants