-
Notifications
You must be signed in to change notification settings - Fork 152
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Miscellaneous Scala clean up (#4055)
This PR makes a couple quick miscellaneous changes: - Updates `maven-compiler-plugin` and `scala-maven-plugin` to their latest versions - Set the Java version with `<release>` rather than `<source>` and `<target>` - `<source>` and `<target>` only set the source code and generated class file formats, but do not take into account API changes between Java releases - This `<release>` tag should automatically be respected by `scala-maven-plugin` as well (once #4041 is fixed) - Disable various Scala language extensions and enable `-Werror` - Not strictly necessary, but I figure this will minimize complications when we port to Scala 2.13.x and later Java - Delete the `KORE.Att()` sugar for `Att.empty()` - Unrelated, the indirection just seemed pointless - Delete `ScalaSugar` - It's only purpose was for implicit conversions, which requires a Scala language extension The commit history is clean, and I recommend reviewing this one commit at a time. --------- Co-authored-by: Bruce Collie <[email protected]> Co-authored-by: rv-jenkins <[email protected]>
- Loading branch information
1 parent
3d2d897
commit d861d9e
Showing
42 changed files
with
243 additions
and
190 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.