-
Notifications
You must be signed in to change notification settings - Fork 152
EIP-7623 Increase calldata cost #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anvacaru
wants to merge
13
commits into
master
Choose a base branch
from
eip-7623
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palinatolmach
approved these changes
Jul 3, 2025
... | ||
</k> | ||
<schedule> SCHED </schedule> | ||
<gasPrice> _ => #effectiveGasPrice(TXID) </gasPrice> | ||
<callGas> _ => GLIMIT -Int G0(SCHED, DATA, false) </callGas> | ||
<callGas> _ => GLIMIT -Int G0(SCHED, DATA, false)</callGas> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a typo?
Suggested change
<callGas> _ => GLIMIT -Int G0(SCHED, DATA, false)</callGas> | |
<callGas> _ => GLIMIT -Int G0(SCHED, DATA, false) </callGas> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Ctxfloor
function to calculate floor price for transactions#finalizeTx
to take an additional parameter for floor gas costmaxInt
to use the higher of the standard calculation or the floor price#tokensInCalldata
to count zero and non-zero bytesfinalizeTx
Reasoning:
There are three cells used for gas computation
<gas>
: gas available for current message<callGas>
: gas explicitly allocated for a particular call or sub-call in the EVM.#loadTx
starts a transaction, it takes thegasLimit
value of the transaction and subtracts the21000 + (STANDARD_TOKEN_COST * tokens_in_calldata) + isContractCreation * (32000 + INITCODE_WORD_COST * words(calldata))
. The result is then stored in the<gas>
cell.#deductGas
will subtract from<gas>
the cost of executing each opcode.#finalizeTx(false)
rules, the refund mechanism is executed, and then the block gas used cell is incremented byGLIMIT - GAVAIL
, which accounts for both the initial gas subtracted inloadTx
, execution costs, and any refunds available.To apply the new formula
The gasUsed value with the maximum value in between
GLIMIT-GAVAIL
and21000 +TOTAL_COST_FLOOR_PER_TOKEN * tokens_in_calldata
.