-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-4844: Add Blob transaction type #2690
Merged
automergerpr-permission-manager
merged 17 commits into
master
from
pi2/robertorosmaninho/eip-4844
Jan 23, 2025
Merged
EIP-4844: Add Blob transaction type #2690
automergerpr-permission-manager
merged 17 commits into
master
from
pi2/robertorosmaninho/eip-4844
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the EIP specification: "The field `to` deviates slightly from the semantics with the exception that it *MUST NOT* be `nil` and therefore must always represent a 20-byte address. This means that blob transactions cannot have the form of a create transaction."
dwightguth
reviewed
Jan 21, 2025
Implementing parsing features for `txVersionedHashes` and `txMaxBlobFee`
ehildenb
reviewed
Jan 22, 2025
ehildenb
reviewed
Jan 22, 2025
Robertorosmaninho
changed the title
EIP-4844: Add DynamicFee transaction type
EIP-4844: Add BlobFee transaction type
Jan 22, 2025
Robertorosmaninho
changed the title
EIP-4844: Add BlobFee transaction type
EIP-4844: Add Blob transaction type
Jan 22, 2025
dwightguth
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine but I'll let RV approve. Note my comment on the suggestion that was prematurely marked as resolved.
anvacaru
reviewed
Jan 23, 2025
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
anvacaru
approved these changes
Jan 23, 2025
anvacaru
reviewed
Jan 23, 2025
anvacaru
reviewed
Jan 23, 2025
automergerpr-permission-manager
bot
deleted the
pi2/robertorosmaninho/eip-4844
branch
January 23, 2025 17:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new type of EIP-2718 transaction type, the Blob transaction specified in the EIP-4844. This is the first from a series of PR needed to fully support the EIP.
This PR also extends:
txMaxBlobFee
(Int) andtxVersionedHashes
(JSONs). This last one may be just a temporary solution, as theBLOBHASH
opcode needs a list where it can access theith
element.