EIP-7610: Revert creation in case of non-empty storage #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
requested review from
anvacaru,
theo25,
dwightguth and
mariaKt
anvacaru
approved these changes
Jan 21, 2025
dwightguth
requested changes
Jan 21, 2025
Robertorosmaninho
force-pushed
the
eip-7610
branch
from
2dc0979 to
db7b8e7
Compare
anvacaru
approved these changes
Jan 23, 2025
dwightguth
reviewed
Jan 23, 2025
|
|
||
| rule <k> #newExistingAccount ACCT => .K ... </k> | ||
| <account> | ||
| <acctID> ACCT </acctID> | ||
| <code> CODE </code> | ||
| <nonce> 0 </nonce> | ||
| <storage> _ => .Map </storage> | ||
| <storage> STORAGE </storage> |
There was a problem hiding this comment.
Minor optimization. Match here against .Map instead of putting it in the side condition.
dwightguth
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement EIP-7610.
This EIP amends EIP-684 with one extra condition, requiring empty storage for contract deployment.
EIP-684 was implemented here:27d15be