Avoid PUSH data when computing jumpdests #2460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a mistake I made in my previous PR #2441. When computing the valid JUMPTESTS, I omitted the case in which the
0x5B
byte could have been part of aPUSH(N)
opcode.I've modified the
_compute_jumpdests
function to first check if the current byte is aPUSH(N)
and skipbyte - PUSH1 +2
bytes.i.e. if byte is
PUSH1
, it skips0x60 - 0x60 + 2
bytes where one byte is the data to be pushed and one byte is the opcode itself.