Add infrastructure to KEVM for Maude Backend #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
force-pushed
the
maude3
branch
3 times, most recently
from
8ffe98e to
5a86ffd
Compare
dwightguth
force-pushed
the
maude3
branch
2 times, most recently
from
6e82aaa to
923fdbe
Compare
anvacaru
reviewed
Oct 24, 2023
ehildenb
approved these changes
Oct 24, 2023
|
Okay, this is a problem. The test suite is so flaky that I've been spending days trying to get this merged. Days. |
|
I agree. Maybe the frontend could be made to not launch so many Z3s? That was an initial guess at a solution. Other things are being implemented, like better retrying in haskell backend on Z3 failures. We've also been reconfiguring parallelism and runner memory allocation. Investigation welcome! |
|
I mean, if we can't solve this immediately, what we really need to do is to implement a policy that only the oldest approved PR in the repo is allowed to be merged. Otherwise we end up with some PRs getting starved and never getting merged, ever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the kevm_pyk package so it is capable of building and using the maude backend when sending RPC requests. This code is still unused; the kontrol codebase needs a separate PR in order to start the maude backend and make use of it when invoking kontrol.