Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kontrolx and associated tests/files #2103

Merged
merged 21 commits into from
Nov 8, 2023
Merged

Remove kontrolx and associated tests/files #2103

merged 21 commits into from
Nov 8, 2023

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Oct 4, 2023 •
edited
Loading

Blocked on: #2135
Blocked on: #2152

Fixes #2113

This removes the Kontrolx modules completely.

  • Removes the code in kevm-pyk/src/kontrolx
  • Adjusts the tests in kevm-pyk/src/tests/ to remove all references to kontrolx.
  • Updates the Nix flake and lock file and Docker image to not include Foundry/solc anymore.
  • Removes the kontrolx CLI arguments that existed in KEVMCLIArgs.
  • Removes the reference to a Foundry. rule in cut_point_rules.

@ehildenb ehildenb marked this pull request as ready for review October 18, 2023 20:08
@ehildenb ehildenb self-assigned this Oct 18, 2023
tothtamas28
tothtamas28 reviewed Oct 19, 2023
View reviewed changes
.github/workflows/test-pr.yml Outdated Show resolved Hide resolved
kevm-pyk/src/kevm_pyk/kdist/plugin.py Outdated Show resolved Hide resolved
kevm-pyk/src/kevm_pyk/utils.py Outdated Show resolved Hide resolved
@yale-vinson yale-vinson added the enhancement New feature or request label Oct 23, 2023
@ehildenb ehildenb mentioned this pull request Oct 24, 2023
Merged
@ehildenb ehildenb marked this pull request as draft October 30, 2023 19:29
@ehildenb ehildenb force-pushed the remove-kontrolx branch 3 times, most recently from 7885790 to f349ffe Compare November 2, 2023 16:54
@ehildenb ehildenb mentioned this pull request Nov 2, 2023
Merged
@ehildenb ehildenb force-pushed the remove-kontrolx branch 3 times, most recently from 4e2ff8e to 298e572 Compare November 3, 2023 15:51
@ehildenb ehildenb marked this pull request as ready for review November 6, 2023 16:52
@ehildenb ehildenb requested a review from tothtamas28 November 6, 2023 16:52
@rv-jenkins rv-jenkins merged commit 1230711 into master Nov 8, 2023
11 checks passed
@rv-jenkins rv-jenkins deleted the remove-kontrolx branch November 8, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothtamas28 tothtamas28 tothtamas28 approved these changes

@palinatolmach palinatolmach Awaiting requested review from palinatolmach

@nwatson22 nwatson22 Awaiting requested review from nwatson22

Assignees

@ehildenb ehildenb

Labels
automerge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove kontrolx
6 participants
@ehildenb @tothtamas28 @palinatolmach @rv-jenkins @yale-vinson @anvacaru