Add struct support #2051
Closed
Add struct support #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvacaru
reviewed
Aug 31, 2023
anvacaru
reviewed
Aug 31, 2023
anvacaru
reviewed
Aug 31, 2023
27e14b7
This reverts commit 6ce697d.
anvacaru
reviewed
Sep 5, 2023
anvacaru
reviewed
Sep 5, 2023
palinatolmach
requested review from
ehildenb and
nwatson22
and removed request for
ehildenb and
nwatson22
|
@nwatson22 @ehildenb can I ask for your help with reviewing this PR? @anvacaru and I looked at it, but would like to get your opinion too, when you have time. |
This was referenced Sep 28, 2023
yale-vinson
assigned spencerhaoxiao and palinatolmach and unassigned palinatolmach and iFrostizz
|
Closing as these changes are included in #2136 and runtimeverification/kontrol#78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for user-defined structs in solc_to_k
Because structs are tuples under the hood https://docs.soliditylang.org/en/latest/abi-spec.html#handling-tuple-types and that they are not tightly packed (two uint8 are taking 2 words in the calldata), we can just recursively unpack the types from the ABI.