Fix cancelAllNonExecutedProposals in the timelock model

runtimeverification · Jul 9, 2024 · 60a2a5f · 60a2a5f
1 parent 8a8905a
commit 60a2a5f
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/contracts/model/EmergencyProtectedTimelockModel.sol b/contracts/model/EmergencyProtectedTimelockModel.sol
@@ -124,11 +124,13 @@ contract EmergencyProtectedTimelockModel {
     function cancelAllNonExecutedProposals() public {
         require(msg.sender == governance, "Caller is not authorized to cancel proposal.");
 
-        // Loop through all the proposals stored in the contract.
-        for (uint256 i = 0; i < nextProposalId; i++) {
-            // Ensure that only proposals in 'Submitted' or 'Scheduled' status are canceled.
-            if (proposals[i].status != ProposalStatus.Executed) {
-                proposals[i].status = ProposalStatus.Canceled;
+        if (nextProposalId > 0) {
+            // Loop through all the proposals stored in the contract.
+            for (uint256 i = 0; i < nextProposalId; i++) {
+                // Ensure that only proposals in 'Submitted' or 'Scheduled' status are canceled.
+                if (proposals[i].status != ProposalStatus.Executed) {
+                    proposals[i].status = ProposalStatus.Canceled;
+                }
             }
         }
     }