Repository navigation
fix(cohere-embedding): add batch size validation with 96 limit for Cohere API - #18915
Merged
logan-markewich merged 1 commit intoJun 2, 2025
Merged
logan-markewich merged 1 commit into
logan-markewich merged 1 commit into
Conversation
- Add MAX_EMBED_BATCH_SIZE constant set to 96 - Validate embed_batch_size in __init__ method - Update docstring to document the batch size limitation - Raise ValueError when batch size exceeds API limit
logan-markewich
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add batch size validation for Cohere Embedding API to enforce the 96 batch size limit imposed by Cohere's API. This prevents runtime errors by catching invalid batch sizes during initialization, providing better error messages and preventing unnecessary API calls that would fail.
The change adds:
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods