feat: support custom runtimeClass and topology namespace #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espace - Allow configuring a custom `runtimeClass.name` to avoid conflict with NVIDIA's default runtime - Topology server namespace in `nvidia-smi` is now configurable via the `TOPOLOGY_CM_NAMESPACE` environment variable instead of being hardcoded to `gpu-operator` ### Example Helm upgrade command ```bash helm upgrade --install fake-gpu-operator ~/git/fake-gpu-operator/deploy/fake-gpu-operator \ --namespace runai --create-namespace \ --set runtimeClass.name=fake-gpu
mu8086
changed the title
mu8086
changed the title
gshaibi
reviewed
Sep 7, 2025
There was a problem hiding this comment.
Thank you very much @mu8086 for your contribution!
From what I understand from your comment, you wish to run both the Fake GPU Operator and the original one together on the same cluster.
Unfortunately this is not supported yet.
I'd love to hear more about this use case.
Regardless, configuring the RuntimeClass name and respecting the release namespace in nvidia-smi seems reasonable - I left a couple of comments.
|
|
||
| // Send http request to topology-server to get the topology | ||
| topologyUrl := "http://topology-server.gpu-operator/topology/nodes/" + nodeName | ||
| topologyUrl := fmt.Sprintf("http://topology-server.%s/topology/nodes/%s", |
There was a problem hiding this comment.
Please inject and use a FAKE_GPU_OPERATOR_NAMESPACE instead
| kind: RuntimeClass | ||
| metadata: | ||
| name: nvidia | ||
| name: {{ .Values.runtimeClass.name | default "fake-nvidia" }} |
There was a problem hiding this comment.
I suggest we keep the default nvidia to better fake the Nvidia GPU Operator behavior.
| COMPONENTS?=device-plugin status-updater kwok-gpu-device-plugin status-exporter topology-server mig-faker jupyter-notebook | ||
|
|
||
| DOCKER_REPO_BASE=gcr.io/run-ai-lab/fake-gpu-operator | ||
| DOCKER_REPO_BASE?=gcr.io/run-ai-lab/fake-gpu-operator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtimeClass.nameto avoid conflict with NVIDIA's default runtimenvidia-smiis now configurable via theTOPOLOGY_CM_NAMESPACEenvironment variable instead of being hardcoded togpu-operatorExample Helm upgrade command
helm upgrade --install fake-gpu-operator ~/git/fake-gpu-operator/deploy/fake-gpu-operator \ --namespace runai --create-namespace \ --set runtimeClass.name=fake-nvidiaExample: Verified Pod Spec
This Pod verifies that the custom runtimeClass and dynamic topology namespace injection works correctly.
Click to expand pod.yaml