Skip to content

reported conditional operator semantic error #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

reported conditional operator semantic error #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80a64f0
reported conditional operator semantic error
s311354 Mar 11, 2025
76bbe68
ensure memory-safe comparisons
s311354 Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2207,6 +2207,8 @@ static Node *conditional(Token **rest, Token *tok) {
node->cond = cond;
node->then = expr(&tok, tok->next);
tok = skip(tok, ":");
if (tok->at_bol)
error_tok(tok, "expected an expression");
node->els = conditional(rest, tok);
return node;
}
Expand Down
2 changes: 1 addition & 1 deletion tokenize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ void warn_tok(Token *tok, char *fmt, ...) {

// Consumes the current token if it matches `op`.
bool equal(Token *tok, char *op) {
return memcmp(tok->loc, op, tok->len) == 0 && op[tok->len] == '\0';
return strlen(op) == tok->len && strncmp(tok->loc, op, tok->len) == 0;
}

// Ensure that the current token is `op`.
Expand Down