avm1: Reference display objects indirectly by string path#9447

Merged

Dinnerbone merged 32 commits intoruffle-rs:masterfrom

CUB3D:avm1_mc_string_paths

Mar 1, 2023

Commits on Mar 1, 2023

avm1: MovieClips are indirectly referenced by string paths

CUB3D
authored and
Dinnerbone
committed
avm1: Treat MovieClips as strings in add2

CUB3D
authored and
Dinnerbone
committed
avm1: AS-instantiated clips with unload handlers need to have delayed removal, fixes mochi preloader

CUB3D
authored and
Dinnerbone
committed
avm1: Don't convert SuperObjects to Value::MovieClip, or you break classes

CUB3D
authored and
Dinnerbone
committed
avm1: Cache MovieClips in Value::MovieClip, this is required to correctly handle changing DO._name and for perf

CUB3D
authored and
Dinnerbone
committed
avm1: Correctly invalidate cache on clip removal

CUB3D
authored and
Dinnerbone
committed
avm1: Timers attached to clips don't fire when the clip is removed

CUB3D
authored and
Dinnerbone
committed
avm1: Fix add2 coerce

CUB3D
authored and
Dinnerbone
committed
avm1: Locals on removed DisplayObjects can't be accessed, should be undef

CUB3D
authored and
Dinnerbone
committed
avm1: Temporary fix, block events when clips are removed

CUB3D
authored and
Dinnerbone
committed
avm1: In swfv5, resolving a non MovieClip path, should resolve to the first MovieClip parent

CUB3D
authored and
Dinnerbone
committed
test: Add button v5/v6 tests

CUB3D
authored and
Dinnerbone
committed
test: Add test for basic string paths

CUB3D
authored and
Dinnerbone
committed
test: Add test for string paths aliasing

CUB3D
authored and
Dinnerbone
committed
test: Add test for unload and variable scopes

CUB3D
authored and
Dinnerbone
committed
test: Add test for clip constructors and timers

CUB3D
authored and
Dinnerbone
committed
avm1: Fallback to resolving properties on _root when the are not in the current scope

CUB3D
authored and
Dinnerbone
committed
avm1: Fixup clippy lints and formatting

CUB3D
authored and
Dinnerbone
committed
avm1: Fix test failures

CUB3D
authored and
Dinnerbone
committed
tests: Add string paths keypress event test, add support for keydown in input.json

CUB3D
authored and
Dinnerbone
committed
tests: Add more string paths tests

CUB3D
authored and
Dinnerbone
committed
tests: Uniform test naming

CUB3D
authored and
Dinnerbone
committed
avm1: Refactor movieclip path logic

CUB3D
authored and
Dinnerbone
committed
avm1: Remove some mc todos

CUB3D
authored and
Dinnerbone
committed
avm1: Cleanup todos, add even more tests

CUB3D
authored and
Dinnerbone
committed
avm1: Fix beta clippy

CUB3D
authored and
Dinnerbone
committed
avm1: Dont double borrow the cache, update test output

CUB3D
authored and
Dinnerbone
committed
avm1: Fix getVariable when path is an object+var and object is a clip

CUB3D
authored and
Dinnerbone
committed
avm1: More scope fixes

CUB3D
authored and
Dinnerbone
committed
test: Even more tests

CUB3D
authored and
Dinnerbone
committed
avm1: Remove resolved todos, add comment and test about known reference launder issue

CUB3D
authored and
Dinnerbone
committed
avm1: Don't use stack_push when the pushed value can't be an Object

CUB3D
authored and
Dinnerbone
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

avm1: Reference display objects indirectly by string path#9447

avm1: Reference display objects indirectly by string path#9447
Dinnerbone merged 32 commits intoruffle-rs:masterfrom
CUB3D:avm1_mc_string_paths

Commits on Mar 1, 2023

avm1: MovieClips are indirectly referenced by string paths

avm1: Treat MovieClips as strings in add2

avm1: AS-instantiated clips with unload handlers need to have delayed removal, fixes mochi preloader

avm1: Don't convert SuperObjects to Value::MovieClip, or you break classes

avm1: Cache MovieClips in Value::MovieClip, this is required to correctly handle changing DO._name and for perf

avm1: Correctly invalidate cache on clip removal

avm1: Timers attached to clips don't fire when the clip is removed

avm1: Fix add2 coerce

avm1: Locals on removed DisplayObjects can't be accessed, should be undef

avm1: Temporary fix, block events when clips are removed

avm1: In swfv5, resolving a non MovieClip path, should resolve to the first MovieClip parent

test: Add button v5/v6 tests

test: Add test for basic string paths

test: Add test for string paths aliasing

test: Add test for unload and variable scopes

test: Add test for clip constructors and timers

avm1: Fallback to resolving properties on _root when the are not in the current scope

avm1: Fixup clippy lints and formatting

avm1: Fix test failures

tests: Add string paths keypress event test, add support for keydown in input.json

tests: Add more string paths tests

tests: Uniform test naming

avm1: Refactor movieclip path logic

avm1: Remove some mc todos

avm1: Cleanup todos, add even more tests

avm1: Fix beta clippy

avm1: Dont double borrow the cache, update test output

avm1: Fix getVariable when path is an object+var and object is a clip

avm1: More scope fixes

test: Even more tests

avm1: Remove resolved todos, add comment and test about known reference launder issue

avm1: Don't use stack_push when the pushed value can't be an Object