avm2: Improve double click detection #17033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-avm2
kjarosh
force-pushed
the
double-click-index
branch
3 times, most recently
from
e1c5b65 to
ba6ea55
Compare
Dinnerbone
approved these changes
Jul 15, 2024
Dinnerbone
force-pushed
the
double-click-index
branch
from
ba6ea55 to
3c32396
Compare
danielhjacobs
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies code a bit by removing
InteractiveObject.last_clickand using the click index mechanism introduced in #16946. This unifies the behavior between double click events and double/triple click selection.By switching to click index, this PR fixes an issue where clicking the same object twice in quick succession but at completely different coordinates constituted a double click. FP treats this as two separate clicks.
Testing FP on Linux suggests that double click delay is <300 ms, whereas the previous value in Ruffle was 1000 ms. I assume the same mechanism for double click detection is used here as in text selection (i.e. a system setting for double click delay is used on Windows, a low constant on Linux).
This PR effectively changes the double click delay to 500 ms (as it's the default now), but a TODO is already added to make it configurable in the future.
Additionally a test for double clicking is added.