core: Add copy/paste context menu for EditText #16622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
edittext-context-menu
branch
4 times, most recently
from
6289034 to
c9d30bf
Compare
kjarosh
force-pushed
the
edittext-context-menu
branch
from
c9d30bf to
d020f01
Compare
|
I also noticed that the user should not be able to copy/cut the text from a password text field. So I cleaned up the code a bit to prevent logic duplication, handled this case, and added a test. |
kjarosh
force-pushed
the
edittext-context-menu
branch
2 times, most recently
from
0a229fa to
f7289bf
Compare
This simplifies code, as we do not have to access the same elements over and over.
This method is useful for checking whether the given text control code may be applied to the current state of the EditText.
This menu is shown when the EditText is focused and the mouse hovers over it. It has the following elements, which may be disabled when e.g. the field is not editable / selectable: * Cut, * Copy, * Paste, * Delete, * Select All.
This test verifies how FP behaves when pasting with an empty clipboard.
This test verifies how FP behaves with regard to copying or cutting text from a password text field.
Dinnerbone
force-pushed
the
edittext-context-menu
branch
from
f7289bf to
c4bd260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This menu is shown when the EditText is focused and the mouse hovers over it. It has the following elements, which may be disabled when e.g. the field is not editable / selectable:
Additionally, this PR also adds handling for an empty clipboard and prevents copy/cut from password fields.
Related to #1891. Fixes #16474.