Skip to content
Open
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a187405
feat: add comprehensive Alchemist visual regression test suite
claude Nov 15, 2025
2f2eec8
chore: update example/pubspec.lock after adding Alchemist dependency
claude Nov 15, 2025
c211ddc
feat(tests): add comprehensive Alchemist visual regression test suite
claude Nov 15, 2025
0480a90
docs: enhance visual regression testing workflow documentation
claude Nov 15, 2025
761bcc6
docs: add comprehensive test coverage analysis against API docs
claude Nov 15, 2025
ab47a79
feat(tests): achieve 100% visual regression coverage with 82 comprehe…
claude Nov 15, 2025
c96c56a
docs: update test documentation to reflect 100% visual coverage
claude Nov 15, 2025
578a3a4
Merge branch 'rudi-q:main' into claude/alchemist-regression-tests-01X…
davidlrichmond Nov 15, 2025
4d6f473
Merge pull request #1 from davidlrichmond/claude/alchemist-regression…
davidlrichmond Nov 15, 2025
7e62e05
Minor doc changes, MacOS goldens
davidlrichmond Nov 15, 2025
a1b8d90
fix: suppress golden test tag warning by defining tags in dart_test.yaml
claude Nov 15, 2025
525985c
dart_test.yaml golden tag
davidlrichmond Nov 15, 2025
d06eb72
analyzer and format linter
davidlrichmond Nov 15, 2025
67fd913
feat(refactor): add foundation for AnimatedChartPainter refactoring
claude Nov 15, 2025
443d585
feat(refactor): add GeometryCalculator for core chart types
claude Nov 15, 2025
7f4c3c1
feat(refactor): integrate GeometryCalculator into AnimatedChartPainter
claude Nov 15, 2025
f75efea
docs: update REFACTORING_GUIDE.md to reflect Phase 1 completion
claude Nov 15, 2025
4a4ba15
docs: add Phase 1 testing instructions
claude Nov 15, 2025
95ad6c5
fix: correct PointShape/LineStyle imports and point rendering
claude Nov 15, 2025
2efe835
chore: update Linux golden files for axis rendering changes
claude Nov 15, 2025
4132c3e
Merge branch 'alchemist-regression-testing' into claude/update-golden…
davidlrichmond Nov 15, 2025
e206f0e
Merge pull request #2 from davidlrichmond/claude/update-golden-files-…
davidlrichmond Nov 15, 2025
bcc251b
chore: update Linux golden files for axis rendering changes
claude Nov 15, 2025
a8fa996
Revert "Claude/update golden files 01 x8 svey pu gw2ws u8 s sz1 xwq"
davidlrichmond Nov 15, 2025
538db4f
Merge pull request #3 from davidlrichmond/revert-2-claude/update-gold…
davidlrichmond Nov 15, 2025
9fb8b88
Merge pull request #4 from davidlrichmond/claude/golden-updates-only-…
davidlrichmond Nov 15, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions dart_test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Test configuration for cristalyse

# This file defines tags used by the test suite



tags:

# Golden tests use Alchemist for visual regression testing

# Run with: flutter test --tags golden

# Skip with: flutter test --exclude-tags golden

golden:

description: Visual regression tests using golden file screenshots
Comment on lines +1 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Reduce excessive blank lines for better readability.

The YAML structure and tag definition are correct and well-documented. However, the file contains unnecessary blank lines (lines 5–6, 8, 10, 12, 14, 16) interspersed between comments and configuration, making it less compact and harder to scan.

Apply this diff to consolidate the formatting:

-# Test configuration for cristalyse
-
-# This file defines tags used by the test suite
-
- 
-
-tags:
-
-  # Golden tests use Alchemist for visual regression testing
-
-  # Run with: flutter test --tags golden
-
-  # Skip with: flutter test --exclude-tags golden
-
-  golden:
-
-    description: Visual regression tests using golden file screenshots
+# Test configuration for cristalyse
+# This file defines tags used by the test suite
+
+tags:
+  # Golden tests use Alchemist for visual regression testing
+  # Run with: flutter test --tags golden
+  # Skip with: flutter test --exclude-tags golden
+  golden:
+    description: Visual regression tests using golden file screenshots
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Test configuration for cristalyse
# This file defines tags used by the test suite
tags:
# Golden tests use Alchemist for visual regression testing
# Run with: flutter test --tags golden
# Skip with: flutter test --exclude-tags golden
golden:
description: Visual regression tests using golden file screenshots
# Test configuration for cristalyse
# This file defines tags used by the test suite
tags:
# Golden tests use Alchemist for visual regression testing
# Run with: flutter test --tags golden
# Skip with: flutter test --exclude-tags golden
golden:
description: Visual regression tests using golden file screenshots
🤖 Prompt for AI Agents
In dart_test.yaml around lines 1 to 17, there are excessive blank lines between
comments and the tags block; remove the extra empty lines (specifically the
blank lines at/around lines 5–6, 8, 10, 12, 14, 16) so the header comments,
explanatory lines and the tags: / golden: sections are compact and consecutive
while preserving all comments and indentation.

6 changes: 5 additions & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,8 @@ dependencies:
dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^6.0.0
flutter_lints: ^6.0.0
alchemist: ^0.13.0

flutter:
uses-material-design: true
21 changes: 21 additions & 0 deletions test/flutter_test_config.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import 'dart:async';

import 'package:alchemist/alchemist.dart';
import 'package:flutter/material.dart';

Future<void> testExecutable(FutureOr<void> Function() testMain) async {
const isRunningInCi = bool.fromEnvironment('CI', defaultValue: false);

return AlchemistConfig.runWithConfig(
config: AlchemistConfig(
theme: ThemeData(fontFamily: 'Roboto'),
platformGoldensConfig: const PlatformGoldensConfig(
enabled: !isRunningInCi,
),
ciGoldensConfig: const CiGoldensConfig(
enabled: isRunningInCi,
),
),
run: testMain,
);
}
Loading
Loading