-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: comprehensive Alchemist visual regression test suite #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidlrichmond
wants to merge
26
commits into
rudi-q:main
Choose a base branch
from
davidlrichmond:alchemist-regression-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a187405
feat: add comprehensive Alchemist visual regression test suite
claude 2f2eec8
chore: update example/pubspec.lock after adding Alchemist dependency
claude c211ddc
feat(tests): add comprehensive Alchemist visual regression test suite
claude 0480a90
docs: enhance visual regression testing workflow documentation
claude 761bcc6
docs: add comprehensive test coverage analysis against API docs
claude ab47a79
feat(tests): achieve 100% visual regression coverage with 82 comprehe…
claude c96c56a
docs: update test documentation to reflect 100% visual coverage
claude 578a3a4
Merge branch 'rudi-q:main' into claude/alchemist-regression-tests-01X…
davidlrichmond 4d6f473
Merge pull request #1 from davidlrichmond/claude/alchemist-regression…
davidlrichmond 7e62e05
Minor doc changes, MacOS goldens
davidlrichmond a1b8d90
fix: suppress golden test tag warning by defining tags in dart_test.yaml
claude 525985c
dart_test.yaml golden tag
davidlrichmond d06eb72
analyzer and format linter
davidlrichmond 67fd913
feat(refactor): add foundation for AnimatedChartPainter refactoring
claude 443d585
feat(refactor): add GeometryCalculator for core chart types
claude 7f4c3c1
feat(refactor): integrate GeometryCalculator into AnimatedChartPainter
claude f75efea
docs: update REFACTORING_GUIDE.md to reflect Phase 1 completion
claude 4a4ba15
docs: add Phase 1 testing instructions
claude 95ad6c5
fix: correct PointShape/LineStyle imports and point rendering
claude 2efe835
chore: update Linux golden files for axis rendering changes
claude 4132c3e
Merge branch 'alchemist-regression-testing' into claude/update-golden…
davidlrichmond e206f0e
Merge pull request #2 from davidlrichmond/claude/update-golden-files-…
davidlrichmond bcc251b
chore: update Linux golden files for axis rendering changes
claude a8fa996
Revert "Claude/update golden files 01 x8 svey pu gw2ws u8 s sz1 xwq"
davidlrichmond 538db4f
Merge pull request #3 from davidlrichmond/revert-2-claude/update-gold…
davidlrichmond 9fb8b88
Merge pull request #4 from davidlrichmond/claude/golden-updates-only-…
davidlrichmond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Test configuration for cristalyse | ||
|
|
||
| # This file defines tags used by the test suite | ||
|
|
||
|
|
||
|
|
||
| tags: | ||
|
|
||
| # Golden tests use Alchemist for visual regression testing | ||
|
|
||
| # Run with: flutter test --tags golden | ||
|
|
||
| # Skip with: flutter test --exclude-tags golden | ||
|
|
||
| golden: | ||
|
|
||
| description: Visual regression tests using golden file screenshots | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import 'dart:async'; | ||
|
|
||
| import 'package:alchemist/alchemist.dart'; | ||
| import 'package:flutter/material.dart'; | ||
|
|
||
| Future<void> testExecutable(FutureOr<void> Function() testMain) async { | ||
| const isRunningInCi = bool.fromEnvironment('CI', defaultValue: false); | ||
|
|
||
| return AlchemistConfig.runWithConfig( | ||
| config: AlchemistConfig( | ||
| theme: ThemeData(fontFamily: 'Roboto'), | ||
| platformGoldensConfig: const PlatformGoldensConfig( | ||
| enabled: !isRunningInCi, | ||
| ), | ||
| ciGoldensConfig: const CiGoldensConfig( | ||
| enabled: isRunningInCi, | ||
| ), | ||
| ), | ||
| run: testMain, | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Reduce excessive blank lines for better readability.
The YAML structure and tag definition are correct and well-documented. However, the file contains unnecessary blank lines (lines 5–6, 8, 10, 12, 14, 16) interspersed between comments and configuration, making it less compact and harder to scan.
Apply this diff to consolidate the formatting:
📝 Committable suggestion
🤖 Prompt for AI Agents