Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement snowpipe destination config validation #5472

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shekhar-rudder
Copy link
Member

Description

Context

Implementation

  • Made changes in StepsToValidate method to return relevant steps for Snowpipe destination
  • Moved DestinationValidationResponse struct from internal/model package to validations package so that it can be accessed in snowpipestreaming package
  • Added a validator field in snowpipe's Manager struct which is responsible for validating the destination config
  • Made changes in Upload function to call the validator whenever there is an authorization error. And if the response is not successful, the error is being returned.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.91%. Comparing base (6e69bd9) to head (029cccb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5472   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files         458      458           
  Lines       63260    63265    +5     
=======================================
+ Hits        47389    47395    +6     
+ Misses      13220    13218    -2     
- Partials     2651     2652    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RanjeetMishra RanjeetMishra requested review from vyeshwanth and removed request for RanjeetMishra February 5, 2025 06:31
warehouse/validations/steps.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants