chore: make cslb configurable #5451
Conversation
cisse21
force-pushed
the
chore.configurableCSLB
branch
from
ed55f43 to
d06c393
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.41.x #5451 +/- ##
==================================================
- Coverage 74.81% 74.73% -0.09%
==================================================
Files 440 440
Lines 61670 61699 +29
==================================================
- Hits 46140 46108 -32
- Misses 12993 13045 +52
- Partials 2537 2546 +9 ☔ View full report in Codecov by Sentry. |
cisse21
force-pushed
the
chore.configurableCSLB
branch
3 times, most recently
from
cb0224b to
97cc532
Compare
processor/transformer/transformer.go
Outdated
| case "polling": | ||
| return health.NewPollingChecker( | ||
| health.PollingCheckerConfig{}, | ||
| health.NewSimpleProber(trans.config.userTransformationURL), |
There was a problem hiding this comment.
wouldn't using trans.config.userTransformationURL adversely affect destination transformation considering the same client is used..?
There was a problem hiding this comment.
I guess there's no adverse effects, but we're not probing the right endpoint
There was a problem hiding this comment.
Will be fixing this in the new separate clients PR
processor/transformer/transformer.go
Outdated
| @@ -310,6 +315,39 @@ func (t *HTTPLBTransport) NewRoundTripper(scheme, target string, config httplb.T | |||
| return httplb.RoundTripperResult{RoundTripper: t.Transport, Close: t.CloseIdleConnections} | |||
| } | |||
|
|
|||
| func (trans *handle) getPicker() func(prev picker.Picker, allConns conn.Conns) picker.Picker { | |||
There was a problem hiding this comment.
we are adding method that contain logic specific to httplb, to a generic component.
It would be preferable to encapsulate this in a separate component. A simple wrapper on httplb.NewClient would be enough.
Something like
HTTPLBFromConfig(c *config.Config) httplb.Client {
pickerType := config.GetString("Transformer.Client.httplb.pickerType", "power_of_two")
...
return httplb.NewClient(....
}There was a problem hiding this comment.
Done... is this behaviour what you expected?
cisse21
force-pushed
the
chore.configurableCSLB
branch
from
97cc532 to
2bcb2c6
Compare
Description
Linear Ticket
Fixes PIPE-1860
Security