chore: generateTransformationMessage is its own concurrent step #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
changed the title
Sidddddarth
force-pushed
the
chore.newProcessorStep_generateTransformationMessage
branch
from
727f6dc to
eb3998c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5449 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 458 458
Lines 63260 63276 +16
=======================================
+ Hits 47389 47401 +12
- Misses 13220 13222 +2
- Partials 2651 2653 +2 ☔ View full report in Codecov by Sentry. |
ktgowtham
approved these changes
Jan 28, 2025
processor/processor.go
Outdated
| hasMore: false, | ||
| rsourcesStats: rsourcesStats, | ||
| }) | ||
| transMessage, err = proc.generateTransformationMessage(proc.processJobsForDest( |
There was a problem hiding this comment.
not related to this PR. but there's a possibility of duplicate persistence of jobs in events schema and archival?
mihir20
requested changes
Jan 30, 2025
processor/processor.go
Outdated
| @@ -1734,7 +1734,7 @@ func (proc *Handle) processJobsForDest(partition string, subJobs subJob) (*trans | |||
| for _, batchEvent := range jobList { | |||
| var eventParams types.EventParams | |||
| if err := jsonfast.Unmarshal(batchEvent.Parameters, &eventParams); err != nil { | |||
| return nil, err | |||
| panic(err) | |||
There was a problem hiding this comment.
lets return error from here, we can handle error at 1 place only in worker.go
mihir20
reviewed
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
generateTransformationMessage is its own concurrent step.
Includes:
Linear Ticket
Resolves PIPE-1719
Security